247310f370
- features/apps/index.js (/apps*) and features/app-detail/index.js (/app*)
as two features; /apps* registered first so wildcard precedence holds.
Both drive the system-loader-pre-initialized singletons (appsManager /
appTabbedManager) via .initialize(), mirroring the legacy handlers exactly
(incl. app-detail's legacy ?app=/?=name parsing + ?tab=/?config= rewrite).
- kernel/lifecycle.js: ctx.nav(path, addToHistory) so app-detail's empty-name
redirect matches navigate('/apps', false) exactly.
unmount is a no-op for both (shared singletons); the app-tabbed-manager
listener-rebind leak is pre-existing and handled in a follow-up.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
59 lines
2.4 KiB
JavaScript
59 lines
2.4 KiB
JavaScript
// features/app-detail/index.js — the per-app detail page (/app/<name>[/<tab>]).
|
|
//
|
|
// Shares the apps-unified-layout fragment with the App Center grid but renders
|
|
// via window.appTabbedManager (a system-loader singleton; call .initialize(),
|
|
// never `new`). Registered AFTER the apps feature so '/apps*' wins the wildcard
|
|
// match and only true /app* paths land here. mount() mirrors handleAppDetail
|
|
// exactly, including the legacy ?app= / ?=name parsing and the ?tab=/?config=
|
|
// → path rewrite. unmount() is a no-op for now (the singleton is shared); the
|
|
// known unguarded popstate/task-listener re-bind in app-tabbed-manager is
|
|
// addressed in a follow-up (it predates this migration).
|
|
LP.features.register({
|
|
id: 'app-detail',
|
|
routes: ['/app', '/app*'],
|
|
|
|
async mount(ctx) {
|
|
const url = new URL(window.location);
|
|
let appName = url.pathname.replace(/^\/app\/?/, '').split('/')[0];
|
|
appName = appName ? decodeURIComponent(appName) : '';
|
|
if (!appName) appName = url.searchParams.get('app');
|
|
|
|
// Old format ?=appname&tab=tabname
|
|
if (!appName && url.search.includes('?=')) {
|
|
const queryPart = url.search.replace('?', '');
|
|
for (const part of queryPart.split('&')) {
|
|
if (part.startsWith('=')) { appName = part.substring(1); break; }
|
|
}
|
|
}
|
|
|
|
if (!appName) { return ctx.nav('/apps', false); }
|
|
|
|
// Back-compat: rewrite legacy ?tab=/?config= to the canonical path shape
|
|
// before the page reads URL state (replaceState — no extra history entry).
|
|
const legacyTab = url.searchParams.get('tab');
|
|
const legacyConfig = url.searchParams.get('config');
|
|
if (legacyTab || legacyConfig) {
|
|
const tab = legacyTab === 'logs' ? 'tasks' : (legacyTab || 'config');
|
|
const sub = (tab === 'config') ? legacyConfig : null;
|
|
const taskId = url.searchParams.get('task');
|
|
const canonical = window.appPath(appName, tab, sub, taskId);
|
|
if (canonical !== url.pathname + url.search) {
|
|
window.history.replaceState({ route: canonical }, '', canonical);
|
|
}
|
|
}
|
|
|
|
const html = await ctx.loadFragment('/html/apps-unified-layout.html');
|
|
ctx.setContent(html, appName);
|
|
|
|
if (!window.appTabbedManager) {
|
|
throw new Error('AppTabbedManager not initialized by SystemLoader');
|
|
}
|
|
await window.appTabbedManager.initialize();
|
|
},
|
|
|
|
async unmount() {
|
|
// No-op: AppTabbedManager is a shared system-loader singleton. Its
|
|
// listener-rebind leak is pre-existing and fixed separately.
|
|
},
|
|
});
|