'local result=$(cmd)' resets $? to 0 (the local builtin's own exit), so the
following checkSuccess always saw success regardless of cmd's real exit — the
mechanism that masked the de-sudo write failures. Split declaration from
assignment ('local result; result=$(cmd)') across all 235 active-code sites
(84 files) so the command's exit reaches checkSuccess. No behaviour change
beyond $? now being accurate (no set -e in runtime code; multi-line
assignments transform safely).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
40 lines
1.5 KiB
Bash
Executable File
40 lines
1.5 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
installUFWDocker()
|
|
{
|
|
if [[ "$CFG_REQUIREMENT_UFWD" == "true" ]]; then
|
|
if [[ $CFG_DOCKER_INSTALL_TYPE == "rooted" ]]; then
|
|
if [[ "$ISUFWD" == *"command not found"* ]]; then
|
|
isHeader "Install UFW-Docker"
|
|
|
|
((menu_number++))
|
|
echo ""
|
|
echo "---- $menu_number. Installing using linux package installer"
|
|
echo ""
|
|
|
|
local ufwpath="/usr/local/bin/ufw-docker"
|
|
|
|
local result; result=$(sudo wget -O $ufwpath https://github.com/chaifeng/ufw-docker/raw/master/ufw-docker > /dev/null 2>&1)
|
|
checkSuccess "Downloading UFW Docker installation files"
|
|
|
|
local result; result=$(sudo rm -rf $script_dir/wget-log)
|
|
checkSuccess "Setting permissions for install files"
|
|
|
|
local result; result=$(sudo chmod +x $ufwpath)
|
|
checkSuccess "Setting permissions for install files"
|
|
|
|
local result; result=$(runSystem ufw-docker install > /dev/null 2>&1)
|
|
checkSuccess "Installing UFW Docker"
|
|
|
|
local result; result=$(runSystem systemctl restart ufw)
|
|
checkSuccess "Restarting UFW Firewall service"
|
|
|
|
isSuccessful "UFW-Docker has been installed, you can use ufw-docker to see the available commands"
|
|
echo ""
|
|
echo ""
|
|
cd
|
|
fi
|
|
fi
|
|
fi
|
|
}
|