Exhaustive audit (workflow: 19 finders + adversarial per-file verify; 85 raw -> 66 unique -> 39 confirmed) found 36 direct writes into the container-owned tree that bypass runFileOp/runFileWrite/runCfgOp (manager => EACCES in rootless) plus 3 $?-masking sites. Fixes by area: - apps: grafana + prometheus install hooks (sudo chmod -> runFileOp chmod); gluetun provider etag (tee -> runFileWrite). - webui generators: task-create (10 sites: mkdir/chown/tee/jq|tee/sed|tee -> runFileOp/runFileWrite); app-icons (mkdir/cp/mv); config icon cp; system metrics + update throttle stamps (runAsManager touch -> runFileOp touch); setup-lock rm; updater history seed + cp. - task health checker: 4 log writes (tee -a -> runFileWrite -a) + 3 find -delete (-> runFileOp find). - config reconcile: backup cp -> runCfgOp; live cp -> runFileWrite < tmp for container-owned configs (the container user can't read a manager 0600 tmp). - peer pull: tar extract into the container tree -> runFileOp tar. - masking: ip_find_available + folder_group(x2) — split 'local VAR=$(cmd)' so $? reaches the following [[ $? ]] check. 15 files, all pass bash -n; fixed idioms confirmed gone. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: librelad <librelad@digitalangels.vip>
24 lines
637 B
Bash
24 lines
637 B
Bash
#!/bin/bash
|
|
|
|
# Grafana install hooks — pre-flight prereq check + post-start 0777 on the
|
|
# storage folder so Grafana can write its sqlite db regardless of host UID.
|
|
|
|
grafana_install_pre()
|
|
{
|
|
local app_name="$1"
|
|
if ! appInstallCheckRequirements "$app_name" "$CFG_GRAFANA_REQUIRES"; then
|
|
grafana=n
|
|
return 1
|
|
fi
|
|
}
|
|
|
|
grafana_install_post_start()
|
|
{
|
|
local app_name="$1"
|
|
if [ -d "${containers_dir}grafana/grafana_storage" ]; then
|
|
local result
|
|
result=$(runFileOp chmod -R 777 "${containers_dir}grafana/grafana_storage")
|
|
checkSuccess "Set permissions to grafana_storage folder."
|
|
fi
|
|
}
|