'local result=$(cmd)' resets $? to 0 (the local builtin's own exit), so the
following checkSuccess always saw success regardless of cmd's real exit — the
mechanism that masked the de-sudo write failures. Split declaration from
assignment ('local result; result=$(cmd)') across all 235 active-code sites
(84 files) so the command's exit reaches checkSuccess. No behaviour change
beyond $? now being accurate (no set -e in runtime code; multi-line
assignments transform safely).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
16 lines
474 B
Bash
Executable File
16 lines
474 B
Bash
Executable File
#!/bin/bash
|
|
|
|
zipFile()
|
|
{
|
|
local passphrase="$1"
|
|
local zip_file="$2"
|
|
local zip_directory="$3"
|
|
|
|
# Run the SSH command using the existing SSH variables
|
|
local result; result=$(sudo zip -r -MM -e -P $passphrase $zip_file $zip_directory)
|
|
checkSuccess "Zipped up $(basename "$zip_file")"
|
|
|
|
local result; result=$(sudo chown $sudo_user_name:$sudo_user_name "$zip_file")
|
|
checkSuccess "Updating $(basename "$zip_file") with $sudo_user_name ownership"
|
|
}
|