053a620e22
'local result=$(cmd)' resets $? to 0 (the local builtin's own exit), so the
following checkSuccess always saw success regardless of cmd's real exit — the
mechanism that masked the de-sudo write failures. Split declaration from
assignment ('local result; result=$(cmd)') across all 235 active-code sites
(84 files) so the command's exit reaches checkSuccess. No behaviour change
beyond $? now being accurate (no set -e in runtime code; multi-line
assignments transform safely).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
41 lines
1.3 KiB
Bash
41 lines
1.3 KiB
Bash
#!/bin/bash
|
|
|
|
appCrowdSecUpdate() {
|
|
isHeader "Update CrowdSec"
|
|
|
|
((menu_number++))
|
|
echo ""
|
|
echo "---- $menu_number. Updating apt package index."
|
|
echo ""
|
|
local result; result=$(runSystem apt-get update)
|
|
checkSuccess "apt-get update"
|
|
|
|
((menu_number++))
|
|
echo ""
|
|
echo "---- $menu_number. Upgrading CrowdSec packages."
|
|
echo ""
|
|
local result; result=$(runSystem apt-get install -y --only-upgrade crowdsec crowdsec-firewall-bouncer-nftables)
|
|
checkSuccess "Upgraded crowdsec + crowdsec-firewall-bouncer-nftables"
|
|
|
|
((menu_number++))
|
|
echo ""
|
|
echo "---- $menu_number. Refreshing hub collections."
|
|
echo ""
|
|
local result; result=$(runSystem cscli hub update)
|
|
checkSuccess "Refreshed hub index"
|
|
local result; result=$(runSystem cscli hub upgrade)
|
|
checkSuccess "Upgraded installed collections"
|
|
|
|
((menu_number++))
|
|
echo ""
|
|
echo "---- $menu_number. Reloading services."
|
|
echo ""
|
|
local result; result=$(runSystem systemctl reload crowdsec)
|
|
checkSuccess "Reloaded crowdsec agent"
|
|
local result; result=$(runSystem systemctl restart crowdsec-firewall-bouncer)
|
|
checkSuccess "Restarted crowdsec-firewall-bouncer"
|
|
|
|
isSuccessful "CrowdSec updated. Run 'crowdsec_verify_firewall' if you want to re-check nftables priorities."
|
|
menu_number=0
|
|
}
|