LibrePortal/scripts/backup/engine/borg_backup.sh
librelad 7b32dc2e29 fix(backup): clean snapshot-id capture + accept --latest on restore
Found while testing live backups end-to-end:

- Engine backup adapters logged to stdout, so the caller's $() snapshot-id
  capture was polluted with log text — verify-after-backup then failed with
  'no matching ID' on every run. Route their log lines to stderr so stdout is
  only the id (restic/borg/kopia).
- 'libreportal app restore <app> --latest' (as the help advertises) and the
  bare 'restore <app>' both failed: --latest was passed to restic verbatim and
  unset args arrive as the literal 'empty'. Normalise both to 'latest'.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
2026-05-23 16:39:56 +01:00

53 lines
1.5 KiB
Bash

#!/bin/bash
borgBackupAppToLocation()
{
local idx="$1"
local app_name="$2"
local manifest_sha="$3"
local source_path="$containers_dir$app_name"
if [[ ! -d "$source_path" ]]; then
isError "Source path missing for $app_name: $source_path"
return 1
fi
borgEnvExport "$idx" || return 1
local host_tag="${CFG_INSTALL_NAME:-libreportal}"
local archive
archive=$(borgArchiveName "$app_name" "$host_tag")
local comment="app=$app_name host=$host_tag engine=libreportal"
[[ -n "$manifest_sha" ]] && comment+=" manifest=$manifest_sha"
# Exclude the raw DB data dirs on the live path (see backup_db.sh).
local exclude_args=()
local p
while IFS= read -r p; do
[[ -n "$p" ]] && exclude_args+=(--exclude "$p")
done <<< "${backup_exclude_paths:-}"
local loc_name
loc_name=$(resticLocationName "$idx")
# Logs to stderr; stdout is only the archive name for the caller's $().
isNotice "Snapshotting $app_name$loc_name (archive: $archive)" >&2
sudo -E -u "$docker_install_user" borg create \
--comment "$comment" \
--compression auto,zstd \
"${exclude_args[@]}" \
"::$archive" \
"$source_path"
local rc=$?
if [[ $rc -eq 0 ]]; then
isSuccessful "Backup created in $loc_name: $archive" >&2
echo "$archive"
else
isError "Backup to $loc_name failed for $app_name" >&2
fi
borgEnvUnset
return $rc
}