librelad 053a620e22 fix(reliability): split local result=$(cmd) so $? survives for checkSuccess
'local result=$(cmd)' resets $? to 0 (the local builtin's own exit), so the
following checkSuccess always saw success regardless of cmd's real exit — the
mechanism that masked the de-sudo write failures. Split declaration from
assignment ('local result; result=$(cmd)') across all 235 active-code sites
(84 files) so the command's exit reaches checkSuccess. No behaviour change
beyond $? now being accurate (no set -e in runtime code; multi-line
assignments transform safely).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
2026-05-31 03:09:25 +01:00

17 lines
484 B
Bash
Executable File

#!/bin/bash
backupContainerFilesRestore()
{
local app_name="$1"
local source_folder="$containers_dir$app_name"
if [ -d "$temp_backup_folder" ]; then
local result; result=$(copyFiles "loud" "$temp_backup_folder" "$source_folder" $docker_install_user)
checkSuccess "Copying files from temp folder to $app_name folder."
local result; result=$(rm -rf "$temp_backup_folder")
checkSuccess "Removing temp folder as no longer needed."
fi
}