'local result=$(cmd)' resets $? to 0 (the local builtin's own exit), so the
following checkSuccess always saw success regardless of cmd's real exit — the
mechanism that masked the de-sudo write failures. Split declaration from
assignment ('local result; result=$(cmd)') across all 235 active-code sites
(84 files) so the command's exit reaches checkSuccess. No behaviour change
beyond $? now being accurate (no set -e in runtime code; multi-line
assignments transform safely).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
21 lines
688 B
Bash
Executable File
21 lines
688 B
Bash
Executable File
#!/bin/bash
|
|
|
|
dockerServiceStart()
|
|
{
|
|
if [[ $CFG_DOCKER_INSTALL_TYPE == "rooted" ]]; then
|
|
local result; result=$(runSystem systemctl start docker)
|
|
checkSuccess "Starting Docker Service"
|
|
|
|
local result; result=$(runSystem systemctl enable docker)
|
|
checkSuccess "Enabling Docker Service"
|
|
|
|
local result; result=$(runSystem usermod -aG docker $sudo_user_name)
|
|
checkSuccess "Adding user to 'docker' group"
|
|
|
|
local result; result=$(runSystem systemctl restart docker)
|
|
checkSuccess "Restarting Docker service after group addition."
|
|
elif [[ $CFG_DOCKER_INSTALL_TYPE == "rootless" ]]; then
|
|
installDockerRootless;
|
|
fi
|
|
}
|