'local result=$(cmd)' resets $? to 0 (the local builtin's own exit), so the
following checkSuccess always saw success regardless of cmd's real exit — the
mechanism that masked the de-sudo write failures. Split declaration from
assignment ('local result; result=$(cmd)') across all 235 active-code sites
(84 files) so the command's exit reaches checkSuccess. No behaviour change
beyond $? now being accurate (no set -e in runtime code; multi-line
assignments transform safely).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
18 lines
761 B
Bash
Executable File
18 lines
761 B
Bash
Executable File
#!/bin/bash
|
|
|
|
databaseOptionInsert()
|
|
{
|
|
local option="$1"
|
|
local content="$2"
|
|
local table_name=options
|
|
local option_in_db=$(runInstallOp sqlite3 "$docker_dir/$db_file" "SELECT COUNT(*) FROM $table_name WHERE option = '$option';")
|
|
|
|
if [ "$option_in_db" -eq 0 ]; then
|
|
local result; result=$(runInstallOp sqlite3 "$docker_dir/$db_file" "INSERT INTO $table_name (option, content) VALUES ('$option', '$content');")
|
|
checkSuccess "Adding $option to the $table_name table."
|
|
else
|
|
local result; result=$(runInstallOp sqlite3 "$docker_dir/$db_file" "UPDATE $table_name SET option = '$option', content = '$content';")
|
|
checkSuccess "$option already added to the $table_name table. Updating content to $content."
|
|
fi
|
|
}
|