4ce0340ef8
Application backups were driven by one crontab entry per app, each offset by id * CFG_BACKUP_CRONTAB_APP_INTERVAL minutes. That minute offset is written straight into cron's 0-59 minute field, so past ~20 apps it overflowed into an invalid entry that silently never fired, and the fixed spacing could not serialize backups that ran longer than the gap. Replace it with a single daily entry (`libreportal backup scheduled`) that enqueues a backup task per enabled app. The existing systemd task processor drains them serially — no minute overflow, real serialization, and backups are now visible/cancellable in the Tasks UI. Per-app enable is read from CFG_<APP>_BACKUP at schedule time instead of being mirrored into crontab. Removes the stagger machinery (timing/setup/check/remove scripts), the now-unused cron_jobs table + insert, and the CFG_BACKUP_CRONTAB_APP_INTERVAL config knob and its WebUI field. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: librelad <librelad@digitalangels.vip>
33 lines
1.0 KiB
Bash
33 lines
1.0 KiB
Bash
#!/bin/bash
|
|
|
|
# Enqueue a backup for every installed app that has backups enabled. Invoked
|
|
# once daily by the backup scheduler crontab entry. Each app is handed to
|
|
# backupAppSchedule, which queues a task for the processor (WebUI installs) or
|
|
# runs the backup inline (terminal-only installs).
|
|
backupScheduleEnabledApps()
|
|
{
|
|
isHeader "Scheduling backups for enabled applications"
|
|
|
|
if [ ! -f "$docker_dir/$db_file" ]; then
|
|
isError "Database not found: $docker_dir/$db_file"
|
|
return 1
|
|
fi
|
|
|
|
local app_names=()
|
|
while IFS= read -r name; do
|
|
[[ -z "$name" ]] && continue
|
|
app_names+=("$name")
|
|
done < <(sudo sqlite3 "$docker_dir/$db_file" "SELECT name FROM apps WHERE status = 1;")
|
|
|
|
local queued=0
|
|
for name in "${app_names[@]}"; do
|
|
local backup_flag="CFG_${name^^}_BACKUP"
|
|
if [[ "${!backup_flag}" == "true" ]]; then
|
|
backupAppSchedule "$name"
|
|
((queued++))
|
|
fi
|
|
done
|
|
|
|
isSuccessful "Backup scheduling complete — $queued app(s) queued"
|
|
}
|