'local result=$(cmd)' resets $? to 0 (the local builtin's own exit), so the
following checkSuccess always saw success regardless of cmd's real exit — the
mechanism that masked the de-sudo write failures. Split declaration from
assignment ('local result; result=$(cmd)') across all 235 active-code sites
(84 files) so the command's exit reaches checkSuccess. No behaviour change
beyond $? now being accurate (no set -e in runtime code; multi-line
assignments transform safely).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
26 lines
934 B
Bash
Executable File
26 lines
934 B
Bash
Executable File
#!/bin/bash
|
|
|
|
installCrontab()
|
|
{
|
|
if [[ "$CFG_REQUIREMENT_CRONTAB" == "true" ]]; then
|
|
if [[ "$CRONTAB_SETUP" == "false" ]]; then
|
|
isHeader "Crontab Install"
|
|
|
|
# Check to see if already installed
|
|
ISCRON=$( (runAsManager crontab -l) 2>&1 )
|
|
if [[ "$ISCRON" == *"command not found"* ]]; then
|
|
isNotice "Crontab is not installed, setting up now."
|
|
local result; result=$(runSystem apt update)
|
|
checkSuccess "Updating apt for post installation"
|
|
local result; result=$(runSystem apt install cron -y)
|
|
isSuccessful "Installing crontab application"
|
|
local result; result=$(runAsManager crontab -l)
|
|
isSuccessful "Enabling crontab on the system"
|
|
fi
|
|
|
|
isSuccessful "Crontab has been setup on the system"
|
|
#installCrontabSSHScan;
|
|
fi
|
|
fi
|
|
}
|