8b5e02c760
The main sweep — ~260 call sites across ~100 files move from string
concatenation on a single root to appDir/storageAppDirs/storageAppConfigs.
On a single-root install the resolved paths are identical, so this is a
no-op until a location is registered.
Enumerators were the interesting half. `for d in "$containers_dir"/*/`
appears in the menus, the registry/artifact scanners and the DNS setup —
and a shell glob cannot list a rootless 751 tree at all, which is the
same bug config_find_file.sh already documents in a comment. Routing them
through storageAppDirs (which enumerates as the owning user) fixes that
alongside the multi-root work.
Three places needed judgement rather than substitution:
db_app_scan.sh deletes database rows and port allocations for apps whose
folder is missing, and reaps "empty" app dirs. With a storage location
unmounted, every app on it looks exactly like that. Each of those
branches now gates on appStorageAvailable first — an app on an unplugged
drive is skipped with a notice, never deleted.
instance_create.sh rewrites cloned hooks so an instance touches its own
directory instead of the base app's. Its sed matched ${containers_dir}<type>,
which this sweep just replaced with $(appDir <type>) — so it would have
silently stopped redirecting, and an instance would have written to the
original's files (the adguard auth adapter case its own comment warns
about). Now matches both appDir forms, verified against bare, quoted,
unrelated-app, legacy and prose cases.
peer_shell/peer_pull streamed and extracted relative to the primary root.
Both now use the app's own root, and peer_shell keeps a single-root
fallback since it runs as a restricted SSH shell with no LibrePortal env.
Also fixes a pre-existing bug found on the way: webui_app_config.sh
tested "$containers_dir/frontend/data/last_update", one level short of the
real tree under the libreportal app dir, so the WebUI refresh trigger
after a config update has never once fired.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
94 lines
2.5 KiB
Bash
94 lines
2.5 KiB
Bash
#!/bin/bash
|
|
|
|
borgBackupAppToLocation()
|
|
{
|
|
local idx="$1"
|
|
local app_name="$2"
|
|
local manifest_sha="$3"
|
|
local source_path="$(appDir "$app_name")"
|
|
|
|
if [[ ! -d "$source_path" ]]; then
|
|
isError "Source path missing for $app_name: $source_path"
|
|
return 1
|
|
fi
|
|
|
|
borgEnvExport "$idx" || return 1
|
|
|
|
local host_tag="${CFG_INSTALL_NAME:-libreportal}"
|
|
local archive
|
|
archive=$(borgArchiveName "$app_name" "$host_tag")
|
|
local comment="app=$app_name host=$host_tag engine=libreportal"
|
|
[[ -n "$manifest_sha" ]] && comment+=" manifest=$manifest_sha"
|
|
|
|
# Exclude the raw DB data dirs on the live path (see backup_db.sh).
|
|
local exclude_args=()
|
|
local p
|
|
while IFS= read -r p; do
|
|
[[ -n "$p" ]] && exclude_args+=(--exclude "$p")
|
|
done <<< "${backup_exclude_paths:-}"
|
|
|
|
local loc_name
|
|
loc_name=$(resticLocationName "$idx")
|
|
# Logs to stderr; stdout is only the archive name for the caller's $().
|
|
isNotice "Snapshotting $app_name → $loc_name (archive: $archive)" >&2
|
|
|
|
runBackupOp borg create \
|
|
--comment "$comment" \
|
|
--compression auto,zstd \
|
|
"${exclude_args[@]}" \
|
|
"::$archive" \
|
|
"$source_path"
|
|
local rc=$?
|
|
|
|
if [[ $rc -eq 0 ]]; then
|
|
isSuccessful "Backup created in $loc_name: $archive" >&2
|
|
echo "$archive"
|
|
else
|
|
isError "Backup to $loc_name failed for $app_name" >&2
|
|
fi
|
|
|
|
borgEnvUnset
|
|
return $rc
|
|
}
|
|
|
|
borgBackupSystemToLocation()
|
|
{
|
|
local idx="$1"
|
|
local source_path="${configs_dir%/}"
|
|
|
|
if [[ ! -d "$source_path" ]]; then
|
|
isError "System config path missing: $source_path"
|
|
return 1
|
|
fi
|
|
|
|
borgEnvExport "$idx" || return 1
|
|
|
|
local host_tag="${CFG_INSTALL_NAME:-libreportal}"
|
|
# No app is named "system", so the "system-<host>-*" archive namespace can't
|
|
# collide with an app's archives.
|
|
local archive
|
|
archive=$(borgArchiveName "system" "$host_tag")
|
|
local comment="system=config host=$host_tag engine=libreportal"
|
|
|
|
local loc_name
|
|
loc_name=$(resticLocationName "$idx")
|
|
isNotice "Snapshotting system config → $loc_name (archive: $archive)" >&2
|
|
|
|
runBackupOp borg create \
|
|
--comment "$comment" \
|
|
--compression auto,zstd \
|
|
"::$archive" \
|
|
"$source_path"
|
|
local rc=$?
|
|
|
|
if [[ $rc -eq 0 ]]; then
|
|
isSuccessful "System config backed up to $loc_name: $archive" >&2
|
|
echo "$archive"
|
|
else
|
|
isError "System config backup to $loc_name failed" >&2
|
|
fi
|
|
|
|
borgEnvUnset
|
|
return $rc
|
|
}
|