053a620e22
'local result=$(cmd)' resets $? to 0 (the local builtin's own exit), so the
following checkSuccess always saw success regardless of cmd's real exit — the
mechanism that masked the de-sudo write failures. Split declaration from
assignment ('local result; result=$(cmd)') across all 235 active-code sites
(84 files) so the command's exit reaches checkSuccess. No behaviour change
beyond $? now being accurate (no set -e in runtime code; multi-line
assignments transform safely).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
20 lines
617 B
Bash
Executable File
20 lines
617 B
Bash
Executable File
#!/bin/bash
|
|
|
|
moveFile()
|
|
{
|
|
local file="$1"
|
|
local file_name=$(basename "$file")
|
|
local save_dir="$2"
|
|
local save_dir_file=$(basename "$save_dir")
|
|
|
|
if [ -e "$file" ]; then
|
|
# Move as the destination's owner — no root, no chown (see copyFile).
|
|
local op="runInstallOp"
|
|
[[ "$save_dir" == "$containers_dir"* || "$save_dir" == "${LP_CONTAINERS_DIR:-/libreportal-containers}"/* ]] && op="runFileOp"
|
|
local result; result=$($op mv "$file" "$save_dir")
|
|
checkSuccess "Moving $file_name to $save_dir"
|
|
else
|
|
isNotice "Source file does not exist: $file"
|
|
fi
|
|
}
|