'local result=$(cmd)' resets $? to 0 (the local builtin's own exit), so the
following checkSuccess always saw success regardless of cmd's real exit — the
mechanism that masked the de-sudo write failures. Split declaration from
assignment ('local result; result=$(cmd)') across all 235 active-code sites
(84 files) so the command's exit reaches checkSuccess. No behaviour change
beyond $? now being accurate (no set -e in runtime code; multi-line
assignments transform safely).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
26 lines
921 B
Bash
Executable File
26 lines
921 B
Bash
Executable File
#!/bin/bash
|
|
|
|
dockerStopApp()
|
|
{
|
|
local app_name="$1"
|
|
|
|
if [[ -z "$app_name" ]]; then
|
|
isNotice "No app name provided. Unable to stop containers."
|
|
fi
|
|
|
|
isNotice "Stopping Docker containers for '$app_name'. Please wait..."
|
|
|
|
# Stop containers in one go
|
|
local result; result=$(dockerCommandRun "docker ps -aq --filter name=${app_name} | xargs -r docker stop" >/dev/null 2>&1)
|
|
checkSuccess "Stopped Docker containers matching '$app_name'"
|
|
|
|
# App-specific stop hook — host-installed apps define stop<App> to stop
|
|
# their systemd services etc. (mirrors dockerUninstallApp's uninstall<App>
|
|
# hook). No-op for the pure-docker apps that don't define one.
|
|
local app_name_ucfirst="$(tr '[:lower:]' '[:upper:]' <<< ${app_name:0:1})${app_name:1}"
|
|
local stopFuncName="stop${app_name_ucfirst}"
|
|
if declare -f "$stopFuncName" >/dev/null 2>&1; then
|
|
"$stopFuncName"
|
|
fi
|
|
}
|