librelad 2ea6340139 Prune unreadable dirs in the app-config scan
sourceScanFiles "app_configs" runs as the docker install user and walks
all of containers/. Container-created data dirs (e.g. <app>/postgres,
uid 231141 mode 0700 under rootless) aren't listable by that user, so
find printed a "Permission denied" line per dir into the middle of every
app install's output — noise that reads like the install is touching
other apps.

Prune unreadable/non-traversable dirs instead of descending into them.
They never hold a .config, and pruning keeps genuine find errors
visible where a blanket 2>/dev/null would not. Verified the scan returns
the same 10 configs, with no stderr.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-18 21:55:27 +01:00

82 lines
3.5 KiB
Bash
Executable File

#!/bin/bash
sourceScanFiles()
{
local load_type="$1"
local file_pattern
# Specific LibrePortal config files
if [ "$load_type" = "libreportal_configs" ]; then
# Load new subdirectory config files only (no more old structure fallback)
local folder_dir="$configs_dir"
# Load new subdirectory config files with exclusions
while IFS= read -r -d '' file; do
if [ -f "$file" ]; then
local filename=$(basename "$file")
local should_load=true
# Skip .category files and excluded files
if [[ "$file" =~ \.category$ ]] || [[ "$filename" == "app_categories" ]]; then
should_load=false
fi
if [ "$should_load" = true ]; then
source "$file"
# echo "$load_type NEW FILE $file"
fi
fi
done < <(find "$folder_dir" -maxdepth 2 -type f ! -name "*.category" ! -name "config_*" ! -name ".*" ! -name "*.bak" -print0)
# Per-location backup configs live nested at depth 3
# (configs/backup/locations/<idx>/location.config) — source them via
# the dedicated loader so CFG_BACKUP_LOC_<idx>_* vars are populated.
if declare -f sourceBackupLocations >/dev/null 2>&1; then
sourceBackupLocations
fi
# Specific for LibrePortal app container configs
elif [ "$load_type" = "app_configs" ]; then
local file_pattern="*.config"
local folder_dir="$containers_dir"
# Specific for LibrePortal app install scripts
elif [ "$load_type" = "containers" ]; then
local file_pattern="*.sh"
local folder_dir="$install_containers_dir"
else
echo "Invalid load type: $load_type"
fi
# Scanning function for other types (not libreportal_configs).
# app_configs live under /docker/containers (owned by the docker install user
# and not list-readable by the manager), so enumerate them AS that user via
# runFileOp; the manager still sources each (the .config files are o+r). The
# 'containers' install templates are manager-owned, so a plain find suffices.
#
# Unreadable dirs are PRUNED, not descended into: an app's container-created
# data dirs are owned by the container's (sub)uid and mode 0700 — e.g.
# containers/<app>/postgres, uid 231141 under rootless — so even the docker
# install user can't list them, and find would print a "Permission denied"
# line per dir straight into the middle of every install's output. They never
# hold a LibrePortal .config, so skipping them loses nothing; pruning (rather
# than discarding stderr) keeps genuine find errors visible.
if [ "$load_type" != "libreportal_configs" ]; then
local scan_op=""
[[ "$load_type" == "app_configs" ]] && scan_op="runFileOp"
while IFS= read -r -d '' file; do
if [ -f "$file" ]; then
source "$file"
# echo "$load_type FILE $file"
fi
done < <($scan_op find "$folder_dir" -maxdepth 3 \( -type d \( -name 'resources' -o ! -readable -o ! -executable \) -prune \) -o -type f -name "$file_pattern" -print0)
fi
# Load the categories from the file into an array
if [ "$load_type" = "libreportal_configs" ]; then
if [ -f "$configs_dir/app_categories" ]; then
mapfile -t app_categories < $configs_dir/app_categories
fi
fi
}