- backup_files.sh / backup_db.sh: every docker exec/run in the capture, sidecar-discovery, rehydrate and DB-import paths now goes through runFileOp — bare docker can't reach the rootless daemon socket, which made live capture fail (and silently bounce containers) on every rootless install, and would have broken DB restores the same way. - capture/rehydrate stderr is kept and printed on failure instead of being discarded, with a clear message when the image has no tar. - backup_app_start.sh: when no location produced a complete snapshot the backup now returns 1 — the task is marked failed instead of logging a nonexistent/incomplete backup as a success and skipping verification. - restic engine: on restic exit 3 the orphan incomplete snapshot is called out explicitly so nobody restores it believing it is whole. - speedtest: capture /config through the container (root-owned TLS key and logrotate state are unreadable from the host), which also flips its auto strategy to live — no more container stop per backup. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
143 lines
4.4 KiB
Bash
143 lines
4.4 KiB
Bash
#!/bin/bash
|
|
|
|
resticBackupAppToLocation()
|
|
{
|
|
local idx="$1"
|
|
local app_name="$2"
|
|
local manifest_sha="$3"
|
|
local source_path="$containers_dir$app_name"
|
|
|
|
if [[ ! -d "$source_path" ]]; then
|
|
isError "Source path missing for $app_name: $source_path"
|
|
return 1
|
|
fi
|
|
|
|
resticEnvExport "$idx" || return 1
|
|
|
|
local host_tag="${CFG_INSTALL_NAME:-libreportal}"
|
|
local extra_tags=(
|
|
--tag "app=$app_name"
|
|
--tag "host=$host_tag"
|
|
--tag "engine=libreportal"
|
|
)
|
|
[[ -n "$manifest_sha" ]] && extra_tags+=(--tag "manifest=$manifest_sha")
|
|
|
|
# On the live path backup_app_start sets $backup_exclude_paths to the raw
|
|
# DB data dirs the dumps replace; keep them out of the snapshot.
|
|
local exclude_args=()
|
|
local p
|
|
while IFS= read -r p; do
|
|
[[ -n "$p" ]] && exclude_args+=(--exclude "$p")
|
|
done <<< "${backup_exclude_paths:-}"
|
|
|
|
local loc_name
|
|
loc_name=$(resticLocationName "$idx")
|
|
# Logs go to stderr so this function's stdout is ONLY the snapshot id —
|
|
# the caller captures it with $() and feeds it to verify/retention.
|
|
isNotice "Snapshotting $app_name → $loc_name" >&2
|
|
local output
|
|
output=$(runBackupOp restic backup \
|
|
--host "$host_tag" \
|
|
"${extra_tags[@]}" \
|
|
"${exclude_args[@]}" \
|
|
--exclude-caches \
|
|
--json \
|
|
"$source_path" 2>&1)
|
|
local rc=$?
|
|
|
|
local snapshot_id
|
|
snapshot_id=$(echo "$output" | grep -o '"snapshot_id":"[^"]*"' | tail -1 | cut -d'"' -f4)
|
|
|
|
if [[ $rc -eq 0 ]]; then
|
|
isSuccessful "Backup created in $loc_name: ${snapshot_id:0:8}" >&2
|
|
echo "$snapshot_id"
|
|
else
|
|
isError "Backup to $loc_name failed for $app_name" >&2
|
|
echo "$output" | tail -10 >&2
|
|
# restic exit 3 = snapshot written but some source files were
|
|
# unreadable. It stays in the repo but is NOT reported as this run's
|
|
# result — an incomplete snapshot must never be recorded as a good
|
|
# backup (it can be missing exactly the files that matter, e.g. keys).
|
|
if [[ $rc -eq 3 && -n "$snapshot_id" ]]; then
|
|
isError "An INCOMPLETE snapshot ${snapshot_id:0:8} was still written to $loc_name — it is missing the unreadable files listed above; do not rely on it" >&2
|
|
fi
|
|
fi
|
|
|
|
resticEnvUnset
|
|
return $rc
|
|
}
|
|
|
|
resticBackupSystemToLocation()
|
|
{
|
|
local idx="$1"
|
|
local source_path="${configs_dir%/}"
|
|
|
|
if [[ ! -d "$source_path" ]]; then
|
|
isError "System config path missing: $source_path"
|
|
return 1
|
|
fi
|
|
|
|
resticEnvExport "$idx" || return 1
|
|
|
|
local host_tag="${CFG_INSTALL_NAME:-libreportal}"
|
|
local loc_name
|
|
loc_name=$(resticLocationName "$idx")
|
|
isNotice "Snapshotting system config → $loc_name" >&2
|
|
local output
|
|
output=$(runBackupOp restic backup \
|
|
--host "$host_tag" \
|
|
--tag "system=config" \
|
|
--tag "host=$host_tag" \
|
|
--tag "engine=libreportal" \
|
|
--exclude-caches \
|
|
--json \
|
|
"$source_path" 2>&1)
|
|
local rc=$?
|
|
|
|
local snapshot_id
|
|
snapshot_id=$(echo "$output" | grep -o '"snapshot_id":"[^"]*"' | tail -1 | cut -d'"' -f4)
|
|
|
|
if [[ $rc -eq 0 ]]; then
|
|
isSuccessful "System config backed up to $loc_name: ${snapshot_id:0:8}" >&2
|
|
echo "$snapshot_id"
|
|
else
|
|
isError "System config backup to $loc_name failed" >&2
|
|
echo "$output" | tail -10 >&2
|
|
if [[ $rc -eq 3 && -n "$snapshot_id" ]]; then
|
|
isError "An INCOMPLETE snapshot ${snapshot_id:0:8} was still written to $loc_name — it is missing the unreadable files listed above; do not rely on it" >&2
|
|
fi
|
|
fi
|
|
|
|
resticEnvUnset
|
|
return $rc
|
|
}
|
|
|
|
resticBackupAppAllLocations()
|
|
{
|
|
local app_name="$1"
|
|
local manifest_sha="$2"
|
|
local failed=0
|
|
local succeeded=0
|
|
local idx
|
|
|
|
while IFS= read -r idx; do
|
|
[[ -z "$idx" ]] && continue
|
|
if resticBackupAppToLocation "$idx" "$app_name" "$manifest_sha" >/dev/null; then
|
|
succeeded=$((succeeded + 1))
|
|
else
|
|
failed=$((failed + 1))
|
|
fi
|
|
done < <(resticEnabledLocations)
|
|
|
|
if [[ $succeeded -eq 0 ]]; then
|
|
isError "All backup targets failed for $app_name"
|
|
return 1
|
|
fi
|
|
if [[ $failed -gt 0 ]]; then
|
|
isNotice "Backup of $app_name succeeded on $succeeded location(s), failed on $failed"
|
|
else
|
|
isSuccessful "Backup of $app_name succeeded on $succeeded location(s)"
|
|
fi
|
|
return 0
|
|
}
|