librelad 053a620e22 fix(reliability): split local result=$(cmd) so $? survives for checkSuccess
'local result=$(cmd)' resets $? to 0 (the local builtin's own exit), so the
following checkSuccess always saw success regardless of cmd's real exit — the
mechanism that masked the de-sudo write failures. Split declaration from
assignment ('local result; result=$(cmd)') across all 235 active-code sites
(84 files) so the command's exit reaches checkSuccess. No behaviour change
beyond $? now being accurate (no set -e in runtime code; multi-line
assignments transform safely).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
2026-05-31 03:09:25 +01:00

44 lines
1.4 KiB
Bash
Executable File

#!/bin/bash
changeUserGroupOnFolder()
{
local source_user="$1"
local target_user="$2"
local directory="$3"
# Check if the source user exists
id "$source_user" > /dev/null 2>&1
if [ $? -ne 0 ]; then
isError " Source user '$source_user' does not exist."
fi
# Check if the target user exists
id "$target_user" > /dev/null 2>&1
if [ $? -ne 0 ]; then
isError " Target user '$target_user' does not exist."
fi
# Check if the directory exists
if [ ! -d "$directory" ]; then
isError "Directory '$directory' not found."
fi
local result; result=$(find "$directory" -user "$source_user" -exec chown "$target_user" {} +)
checkSuccess "Updating $directory user to be $target_user... This may take a while..."
# Check if the source group exists
local source_group=$(id -g -n "$source_user")
if [ $? -ne 0 ]; then
isError "Unable to determine source group for user '$source_user'."
fi
# Check if the target group exists
local target_group=$(id -g -n "$target_user")
if [ $? -ne 0 ]; then
isError "Unable to determine target group for user '$target_user'."
fi
local result; result=$(find "$directory" -group "$source_group" -exec chgrp "$target_group" {} +)
checkSuccess "Updating $directory group to be $target_user... This may take a while..."
}