Compare commits

..

2 Commits

Author SHA1 Message Date
librelad
5aa51ff3b0 Merge claude/1 2026-05-25 13:53:23 +01:00
librelad
3a97c228da fix(checks): silence docker daemon-down error in webui image check
When the task processor service is down the rootless daemon socket is
absent, so the pre-install `docker images` probe printed a raw daemon
connection error to the terminal. The surrounding notices already convey
the meaningful state (service not running → image not setup), so the raw
error was noise.

Capture the probe output and redirect its stderr to libreportal.log
instead of the terminal, keeping the detail for diagnostics.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
2026-05-25 13:53:23 +01:00

View File

@ -3,7 +3,13 @@
checkLibrePortalWebUIImageRequirement() checkLibrePortalWebUIImageRequirement()
{ {
if [[ $CFG_REQUIREMENT_WEBUI == "true" ]]; then if [[ $CFG_REQUIREMENT_WEBUI == "true" ]]; then
if runFileOp docker images --format "{{.Repository}}:{{.Tag}}" | grep -q "libreportal-service:latest"; then # stderr → log, not the terminal: when the task processor service is down
# the rootless daemon socket is absent and `docker images` prints a daemon
# connection error. The "has not been setup" notice below already conveys
# the outcome, so keep the raw error for diagnostics only.
local images
images=$(runFileOp docker images --format "{{.Repository}}:{{.Tag}}" 2>>"$logs_dir/$docker_log_file")
if echo "$images" | grep -q "libreportal-service:latest"; then
isSuccessful "LibrePortal WebUI Docker Image appears to be setup." isSuccessful "LibrePortal WebUI Docker Image appears to be setup."
else else
isNotice "LibrePortal WebUI Docker Image has not been setup." isNotice "LibrePortal WebUI Docker Image has not been setup."