Compare commits

...

2 Commits

Author SHA1 Message Date
librelad
67cda1c955 Merge claude/2 2026-05-23 21:23:12 +01:00
librelad
90584f0b30 fix(rootless): actually create the docker install user
useradd was missing its login-name argument (and -m), so it failed — silently,
because local result=$(...) swallowed the exit code and checkSuccess reported
success. The rootless install user was therefore never created, which cascaded
into 'invalid user dockerinstall' and a daemon that never came up. Pass the
username + -m (subordinate uid/gid ranges come from login.defs), unmasked.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
2026-05-23 21:23:12 +01:00

View File

@ -6,8 +6,13 @@ installDockerRootlessUser()
if id "$CFG_DOCKER_INSTALL_USER" &>/dev/null; then
isSuccessful "User $CFG_DOCKER_INSTALL_USER already exists."
else
# If the user doesn't exist, create the user
local result=$(sudo useradd -s /bin/bash -d "/home/$CFG_DOCKER_INSTALL_USER")
# Create the rootless docker user. The login name (last arg) was
# missing, so useradd failed silently — masked by local result=$(...)
# — and the user never existed, breaking the whole rootless setup.
# -m makes its home; with SUB_UID/GID configured in login.defs,
# useradd also assigns its subordinate uid/gid ranges (needed for
# rootless). Run unmasked so checkSuccess sees real failures.
sudo useradd -m -s /bin/bash -d "/home/$CFG_DOCKER_INSTALL_USER" "$CFG_DOCKER_INSTALL_USER"
checkSuccess "Creating $CFG_DOCKER_INSTALL_USER User."
updateDockerInstallPassword;
fi