Webstar/LibrePortal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare commits

base: Webstar:052792a7897e494529cae0f2a7ea6e3335fb29eb
Branches Tags
Webstar:main
Webstar:claude/2
Webstar:v0.1.0
...
compare: Webstar:397713d4a860b7f669039011587edd83dc37dcf0
Branches Tags
Webstar:main
Webstar:claude/2
Webstar:v0.1.0

2 Commits
052792a789 ... 397713d4a8

Author SHA1 Message Date
librelad
397713d4a8 Merge claude/1 2026-05-23 15:14:47 +01:00
librelad
1cc4b74b2e style(backup): show Type before Name in the location editor and add dialog 
Type is the choice that determines which other fields appear, so it should be
the first thing you pick; Name is just a label. Reorder the Connection-tab
fields (and the Add-location dialog) to Type → Name.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
 2026-05-23 15:14:47 +01:00
1 changed files with 12 additions and 9 deletions
Show Stats Expand all files Collapse all files

21
containers/libreportal/frontend/js/components/backup/backup-page.js
View File

@ -51,15 +51,18 @@ const BACKUP_LOC_FIELD_DEFS = {
KEEP_YEARLY: { title: 'Keep yearly', description: 'One snapshot per year for this many years.' } KEEP_YEARLY: { title: 'Keep yearly', description: 'One snapshot per year for this many years.' }
}; };
// Type leads each list: it's the choice that shapes the rest of the form, so
// it renders before the friendly Name. ENGINE stays here but is filtered into
// the Advanced tab by locFieldGroups.
const BACKUP_LOC_FIELDS_BY_TYPE = { const BACKUP_LOC_FIELDS_BY_TYPE = {
local: ['NAME', 'ENGINE', 'TYPE', 'PATH_MODE', 'PATH', 'APPEND_ONLY'], local: ['TYPE', 'NAME', 'ENGINE', 'PATH_MODE', 'PATH', 'APPEND_ONLY'],
sftp: ['NAME', 'ENGINE', 'TYPE', 'SSH_USER', 'SSH_HOST', 'SSH_PORT', 'SSH_PATH', 'SSH_AUTH', 'SSH_PASS', 'URI', 'APPEND_ONLY'], sftp: ['TYPE', 'NAME', 'ENGINE', 'SSH_USER', 'SSH_HOST', 'SSH_PORT', 'SSH_PATH', 'SSH_AUTH', 'SSH_PASS', 'URI', 'APPEND_ONLY'],
rest: ['NAME', 'ENGINE', 'TYPE', 'URI', 'APPEND_ONLY'], rest: ['TYPE', 'NAME', 'ENGINE', 'URI', 'APPEND_ONLY'],
s3: ['NAME', 'ENGINE', 'TYPE', 'URI', 'S3_ACCESS_KEY', 'S3_SECRET_KEY', 'APPEND_ONLY'], s3: ['TYPE', 'NAME', 'ENGINE', 'URI', 'S3_ACCESS_KEY', 'S3_SECRET_KEY', 'APPEND_ONLY'],
b2: ['NAME', 'ENGINE', 'TYPE', 'URI', 'B2_ACCOUNT_ID', 'B2_ACCOUNT_KEY', 'APPEND_ONLY'], b2: ['TYPE', 'NAME', 'ENGINE', 'URI', 'B2_ACCOUNT_ID', 'B2_ACCOUNT_KEY', 'APPEND_ONLY'],
gs: ['NAME', 'ENGINE', 'TYPE', 'URI', 'APPEND_ONLY'], gs: ['TYPE', 'NAME', 'ENGINE', 'URI', 'APPEND_ONLY'],
azure: ['NAME', 'ENGINE', 'TYPE', 'URI', 'APPEND_ONLY'], azure: ['TYPE', 'NAME', 'ENGINE', 'URI', 'APPEND_ONLY'],
rclone: ['NAME', 'ENGINE', 'TYPE', 'URI', 'APPEND_ONLY'] rclone: ['TYPE', 'NAME', 'ENGINE', 'URI', 'APPEND_ONLY']
}; };
// Suffixes that live in the editor's "Advanced" tab. configs.json can flag // Suffixes that live in the editor's "Advanced" tab. configs.json can flag
@ -1541,7 +1544,6 @@ class BackupPage {
if (!modal || !body) return; if (!modal || !body) return;
body.innerHTML = ` body.innerHTML = `
<div class="backup-form-grid"> <div class="backup-form-grid">
${this.formInput('__add_name', 'Friendly name', '', 'text', 'e.g. Office NAS')}
${this.formSelect('__add_type', 'Type', 'local', [ ${this.formSelect('__add_type', 'Type', 'local', [
['local', 'Local / mounted path'], ['local', 'Local / mounted path'],
['sftp', 'SFTP'], ['sftp', 'SFTP'],
@ -1552,6 +1554,7 @@ class BackupPage {
['azure', 'Azure'], ['azure', 'Azure'],
['rclone', 'rclone'] ['rclone', 'rclone']
])} ])}
${this.formInput('__add_name', 'Friendly name', '', 'text', 'e.g. Office NAS')}
</div> </div>
<p class="backup-card-hint" style="margin-top:12px">The location starts disabled — fill in its connection details on the next screen, then toggle Enabled.</p> <p class="backup-card-hint" style="margin-top:12px">The location starts disabled — fill in its connection details on the next screen, then toggle Enabled.</p>
`; `;