1 Commits

Author SHA1 Message Date
librelad
988297e8de compose: fall back to docker-compose.yml when the app's config is out of scope
dockerComposeUp and dockerComposeDown derive compose_file from $compose_setup,
which setupBasicScanVariables reads from CFG_<APP>_COMPOSE_FILE — a variable
that is only set once the app's config has been sourced, and is not always. A
restore wipes and re-creates the app folder around those calls.

setupBasicScanVariables already handles that, falling back to the standard file.
Neither compose function did: with compose_setup empty, neither branch ran,
compose_file stayed UNSET, and the guard

    [ ! -f "$(appDir "$app")/$compose_file" ]

then tested the app DIRECTORY, which is never a regular file. So the app was
reported as having no compose file and quietly not started.

Found restoring an app on a clean install: the restore ran to completion and
reported success, having neither stopped nor started the app —

    ---- 3. Shutting down container(s) for restoration
    ! Notice Unable to find the compose file to docker compose down this application.
    ---- 10. Starting up the linkding docker service(s)
    ! Notice Unable to find the compose file to docker compose up this application.

— while docker-compose.yml sat in the app directory the whole time. Verified:
with CFG_LINKDING_COMPOSE_FILE unset, dockerComposeUp now starts the app.

scripts/dev/lp-compose-file-test covers the empty case, the normal one, and a
genuinely missing file so the guard still fires when it should.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-28 08:21:11 +01:00