Webstar/LibrePortal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(overview): path deep-link for an expanded Updates row

Browse Source 
The expanded-row deep-link pushed /overview/<tab>?app=<app> — wrong prefix
and a ?query the SPA's path-based router drops on a cold load, so the row
never reopened from a shared URL. Switch to /apps/overview/updates/<app>,
matching the Migrate/Backups sub-tab path pattern, and parse the app from
that path segment in _honorAppDeepLink so the row expands on cold load too.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
librelad 2026-07-18 22:03:36 +01:00
parent 8ec608f82d
commit f9c29df415
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
containers/libreportal/frontend/components/apps/overview/js/overview-manager.js
View File

@ -186,7 +186,7 @@ class OverviewManager {
case 'updates': { case 'updates': {
// Preserve which rows are expanded across a rebuild — a background // Preserve which rows are expanded across a rebuild — a background
// task-refresh repaints the whole table, so restore ALL open rows, not // task-refresh repaints the whole table, so restore ALL open rows, not
// just the single ?app= deep-link. // just the single /apps/overview/updates/<app> path deep-link.
const open = Array.from(document.querySelectorAll('#overview-view .ov-row-details:not([hidden])')) const open = Array.from(document.querySelectorAll('#overview-view .ov-row-details:not([hidden])'))
.map((d) => d.id.replace(/^ov-detail-/, '')); .map((d) => d.id.replace(/^ov-detail-/, ''));
const anyUpdate = !!(this.updater && this.updater.apps.some((a) => a.update_available)); const anyUpdate = !!(this.updater && this.updater.apps.some((a) => a.update_available));
@ -278,10 +278,13 @@ class OverviewManager {
} }
} }
// Open the row named by ?app=<name> on load / repaint — makes an expanded row // Open the row named by the /apps/overview/updates/<app> path segment on
// a shareable URL, mirroring the Tasks page's ?task=<id> deep-link. // load / repaint — makes an expanded row a shareable URL, mirroring the
// Migrate/Backups sub-tab path deep-links (and unlike a ?query it survives
// the SPA's path-based router on a cold load).
_honorAppDeepLink() { _honorAppDeepLink() {
const app = new URLSearchParams(window.location.search).get('app'); const seg = window.location.pathname.replace(/^\/apps\/overview\/updates\/?/, '').split('/')[0];
const app = seg ? decodeURIComponent(seg) : '';
if (!app) return; if (!app) return;
const details = document.getElementById(`ov-detail-${app}`); const details = document.getElementById(`ov-detail-${app}`);
if (details && details.hidden) this._openDetail(app); if (details && details.hidden) this._openDetail(app);
@ -564,13 +567,13 @@ class OverviewManager {
if (!app) return; if (!app) return;
const details = document.getElementById(`ov-detail-${app}`); const details = document.getElementById(`ov-detail-${app}`);
if (!details) return; if (!details) return;
const base = `/overview/${this.current || 'updates'}`; const base = `/apps/overview/${this.current || 'updates'}`;
if (!details.hidden) { if (!details.hidden) {
this._closeDetail(app); this._closeDetail(app);
this._pushUrl(base, true); this._pushUrl(base, true);
} else { } else {
this._openDetail(app); this._openDetail(app);
this._pushUrl(`${base}?app=${encodeURIComponent(app)}`, true); this._pushUrl(`${base}/${encodeURIComponent(app)}`, true);
} }
} }
@ -581,7 +584,7 @@ class OverviewManager {
// Fill (lazily) + show a row's detail body. URL/history is handled by the // Fill (lazily) + show a row's detail body. URL/history is handled by the
// caller, so this is safe to call when restoring multiple rows after a // caller, so this is safe to call when restoring multiple rows after a
// rebuild without each one clobbering the ?app= deep-link. // rebuild without each one clobbering the /apps/overview/updates/<app> deep-link.
_openDetail(app) { _openDetail(app) {
const details = document.getElementById(`ov-detail-${app}`); const details = document.getElementById(`ov-detail-${app}`);
if (!details) return; if (!details) return;