From 22203a7f60c433e5b13eac0e0fb1d4cc554cf9e5 Mon Sep 17 00:00:00 2001 From: librelad Date: Wed, 27 May 2026 15:39:38 +0100 Subject: [PATCH] ui(tasks): brighten empty-state $ line + fix "No all tasks tasks found" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit .task-command was still using var(--status-success) (#28a745) which reads muddy olive against the nebula gradient — the same dimming the status pills and apps-installed pill already work around with #86efac. The empty-state row ("$ No tasks found …") was the most visible offender. Switches .task-command to the same bright mint already used elsewhere. Same edit, while I was there: the empty-state copy interpolated categoryName.toLowerCase() as `No ${cat} tasks found`, so the "All Tasks" category produced "No all tasks tasks found". Special-cases the all bucket and strips the trailing word when the category name already includes it ("Running Tasks" → "No running tasks found", not "running tasks tasks"). Signed-off-by: librelad --- containers/libreportal/frontend/css/tasks.css | 6 +++++- .../frontend/js/components/tasks/tasks-manager.js | 14 ++++++++++++-- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/containers/libreportal/frontend/css/tasks.css b/containers/libreportal/frontend/css/tasks.css index 5a9b155..010a2f7 100644 --- a/containers/libreportal/frontend/css/tasks.css +++ b/containers/libreportal/frontend/css/tasks.css @@ -329,7 +329,11 @@ } .task-command { - color: var(--status-success); + /* Bright mint to match the .status-running / .status-completed pills. + The theme's --status-success (#28a745) reads muddy olive on nebula — + this is the same #86efac treatment used by the status pills + the + setup-wizard valid border + the apps "Installed" pill. */ + color: #86efac; font-family: 'Courier New', monospace; font-size: 11px; flex: 1; diff --git a/containers/libreportal/frontend/js/components/tasks/tasks-manager.js b/containers/libreportal/frontend/js/components/tasks/tasks-manager.js index 4252c10..36d17b7 100755 --- a/containers/libreportal/frontend/js/components/tasks/tasks-manager.js +++ b/containers/libreportal/frontend/js/components/tasks/tasks-manager.js @@ -491,8 +491,18 @@ class TasksManager { if (this.highlightedTaskId) { message = `Task ${this.highlightedTaskId} not found`; } else { - const categoryName = this.getCategoryDisplayName(this.currentCategory); - message = `No ${categoryName.toLowerCase()} tasks found`; + // Category display names sometimes already end in "Tasks" (e.g. + // "All Tasks", "Running Tasks") — naive interpolation produced + // "No all tasks tasks found". Strip the trailing word when + // present, and special-case the "all" bucket to read naturally. + const catLow = this.getCategoryDisplayName(this.currentCategory).toLowerCase(); + if (catLow === 'all tasks' || catLow === 'all') { + message = 'No tasks found'; + } else if (catLow.endsWith(' tasks')) { + message = `No ${catLow} found`; + } else { + message = `No ${catLow} tasks found`; + } } container.innerHTML = `