From 77b50e52268903d7cf233711c8110c8c329b8d3c Mon Sep 17 00:00:00 2001 From: librelad Date: Tue, 18 Aug 2026 23:23:05 +0100 Subject: [PATCH] refactor(config): drop three more keys nothing reads Same sweep as AUTH_PROFILE, run across all 110 key suffixes in the app configs. CFG_GITEA_ADMIN_EMAIL and CFG_INVIDIOUS_ADMIN_EMAIL: both apps' auth adapters take an email argument for createUser but never read or persist the config key, so it sat empty forever. bookstack, mattermost and rocketchat do read theirs; these two were copies that never got wired. CFG_CROWDSEC_AUTO_UPDATE: superseded by UPDATE_TYPE (auto|manual), which crowdsec also declares. The only AUTO_UPDATE readers left are CFG_GIT_AUTO_UPDATE and CFG_REQUIREMENT_CONFIGS_AUTO_UPDATE, neither of them per-app. Not removed, because each is a gap in the code rather than a key to delete, and deleting would cement the bug: CFG_CROWDSEC_HOST_SERVICE (documented as the unit stop/restart hits, but only HOST_SERVICES is ever read), CFG_CROWDSEC_LAPI_HOST and CFG_CROWDSEC_BOUNCER_NAME_TRAEFIK (the bouncer name is hardcoded in crowdsec_install_host.sh, so editing the setting does nothing). Co-Authored-By: Claude Opus 5 --- containers/crowdsec/crowdsec.config | 1 - containers/gitea/gitea.config | 1 - containers/invidious/invidious.config | 1 - 3 files changed, 3 deletions(-) diff --git a/containers/crowdsec/crowdsec.config b/containers/crowdsec/crowdsec.config index 36f3865..d80526f 100644 --- a/containers/crowdsec/crowdsec.config +++ b/containers/crowdsec/crowdsec.config @@ -36,7 +36,6 @@ CFG_CROWDSEC_PROMETHEUS_LISTEN=0.0.0.0:6060 # BOUNCER = attach the Traefik bouncer middleware to every public route # CFG_CROWDSEC_ENABLED=true -CFG_CROWDSEC_AUTO_UPDATE=true CFG_CROWDSEC_COMMUNITY_BLOCKLIST=true CFG_CROWDSEC_CONSOLE_ENROLL=false CFG_CROWDSEC_CONSOLE_TOKEN= diff --git a/containers/gitea/gitea.config b/containers/gitea/gitea.config index 8663099..c7c4ccd 100755 --- a/containers/gitea/gitea.config +++ b/containers/gitea/gitea.config @@ -68,7 +68,6 @@ CFG_GITEA_PORT_1="gitea-service|webui|random:3000|public|tcp|false|true|true|Web CFG_GITEA_PORT_2="gitea-service|ssh|random:22|private|tcp|false|false|false|Git SSH Access|" CFG_GITEA_ADMIN_USER= -CFG_GITEA_ADMIN_EMAIL= # # Recorded by the auth tools, not by the installer. Gitea seeds no account at # install — the first admin is created from the WebUI (Create Account), and the diff --git a/containers/invidious/invidious.config b/containers/invidious/invidious.config index 152f2c4..c642c20 100755 --- a/containers/invidious/invidious.config +++ b/containers/invidious/invidious.config @@ -66,7 +66,6 @@ CFG_INVIDIOUS_NETWORK=default CFG_INVIDIOUS_PORT_1="invidious-service|webui|random:3000|public|tcp|false|true|true|Web Interface||invidious" CFG_INVIDIOUS_ADMIN_USER= -CFG_INVIDIOUS_ADMIN_EMAIL= # # Recorded by the auth tools, not by the installer. Invidious seeds no account at # install — the first admin is created from the WebUI (Create Account), and the