From 3a97c228da284c3d1c2cc7d329a51eb23645bce1 Mon Sep 17 00:00:00 2001 From: librelad Date: Mon, 25 May 2026 13:53:23 +0100 Subject: [PATCH] fix(checks): silence docker daemon-down error in webui image check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When the task processor service is down the rootless daemon socket is absent, so the pre-install `docker images` probe printed a raw daemon connection error to the terminal. The surrounding notices already convey the meaningful state (service not running → image not setup), so the raw error was noise. Capture the probe output and redirect its stderr to libreportal.log instead of the terminal, keeping the detail for diagnostics. Co-Authored-By: Claude Opus 4.7 Signed-off-by: librelad --- scripts/checks/requirements/check_webui_image.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/checks/requirements/check_webui_image.sh b/scripts/checks/requirements/check_webui_image.sh index 1964c8a..d16c50d 100755 --- a/scripts/checks/requirements/check_webui_image.sh +++ b/scripts/checks/requirements/check_webui_image.sh @@ -3,7 +3,13 @@ checkLibrePortalWebUIImageRequirement() { if [[ $CFG_REQUIREMENT_WEBUI == "true" ]]; then - if runFileOp docker images --format "{{.Repository}}:{{.Tag}}" | grep -q "libreportal-service:latest"; then + # stderr → log, not the terminal: when the task processor service is down + # the rootless daemon socket is absent and `docker images` prints a daemon + # connection error. The "has not been setup" notice below already conveys + # the outcome, so keep the raw error for diagnostics only. + local images + images=$(runFileOp docker images --format "{{.Repository}}:{{.Tag}}" 2>>"$logs_dir/$docker_log_file") + if echo "$images" | grep -q "libreportal-service:latest"; then isSuccessful "LibrePortal WebUI Docker Image appears to be setup." else isNotice "LibrePortal WebUI Docker Image has not been setup."