chore(cleanup): delete the orphan tagsProcessorStandardReplacements
Tree-wide audit (working tree + deployed install + every local/remote ref + every reachable commit + unreachable objects via git fsck) found zero external callers. Existed dead since v0.1.0 — never wired in. The function set DOMAINSUBNAME, TIMEZONE, DOCKER_NETWORK (all duplicates of fills that happen elsewhere) plus the two unique-to-it CONFIGS_DIR_TAG + CONTAINERS_DIR_TAG. Those two are already wired directly into the standard tag-fill block in dockerConfigSetupFileWithData (commit 521f08b), so dropping the source file leaves no behavioural gap. Also tighten the comment that explained why we inlined the two tags — don't reference the function we're deleting in the same change. Describe the current behaviour, not the history (per repo convention). Regenerated the auto arrays + function_manifest.sh: the 3 stale entries referencing this function drop out cleanly. files_cli.sh / files_config.sh / files_source.sh also rebuilt — no net content change beyond dropping this one path. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: librelad <librelad@digitalangels.vip>
This commit is contained in:
parent
4d0d41ca7b
commit
4fc155acfa
@ -20,12 +20,11 @@ dockerConfigSetupFileWithData()
|
|||||||
tagsManagerUpdateUniversalTag "$full_file_path" "TIMEZONE_TAG" "$CFG_TIMEZONE"
|
tagsManagerUpdateUniversalTag "$full_file_path" "TIMEZONE_TAG" "$CFG_TIMEZONE"
|
||||||
tagsManagerUpdateUniversalTag "$full_file_path" "CATEGORY_TAG" "$app_category"
|
tagsManagerUpdateUniversalTag "$full_file_path" "CATEGORY_TAG" "$app_category"
|
||||||
tagsManagerUpdateUniversalTag "$full_file_path" "TITLE_TAG" "$app_title"
|
tagsManagerUpdateUniversalTag "$full_file_path" "TITLE_TAG" "$app_title"
|
||||||
# Root-path tags used by the libreportal compose to bind-mount the system's
|
# Root-path tags. The libreportal compose bind-mounts the host system's
|
||||||
# configs + live-data dirs into the WebUI container. Without these the
|
# configs root and the live-app-data root into the WebUI container, and
|
||||||
# CONFIGS_DIR_DATA / CONTAINERS_DIR_DATA placeholders survive into the
|
# those paths get baked here so the deployed compose carries absolutes
|
||||||
# deployed compose and dockerComposeUp refuses to start. (The orphan
|
# (`/libreportal-system/...`, `/libreportal-containers/...`) — anything
|
||||||
# tagsProcessorStandardReplacements function carried these alone — wiring
|
# left as `*_DATA` would make dockerComposeUp refuse to start.
|
||||||
# them in directly so they're always applied to every app's templating.)
|
|
||||||
tagsManagerUpdateUniversalTag "$full_file_path" "CONFIGS_DIR_TAG" "${configs_dir%/}"
|
tagsManagerUpdateUniversalTag "$full_file_path" "CONFIGS_DIR_TAG" "${configs_dir%/}"
|
||||||
tagsManagerUpdateUniversalTag "$full_file_path" "CONTAINERS_DIR_TAG" "${containers_dir%/}"
|
tagsManagerUpdateUniversalTag "$full_file_path" "CONTAINERS_DIR_TAG" "${containers_dir%/}"
|
||||||
# Generic CFG_<APP>_<KEY> -> #LIBREPORTAL|<APP>_<KEY>_TAG| fill. Covers
|
# Generic CFG_<APP>_<KEY> -> #LIBREPORTAL|<APP>_<KEY>_TAG| fill. Covers
|
||||||
|
|||||||
@ -1,32 +0,0 @@
|
|||||||
#!/bin/bash
|
|
||||||
|
|
||||||
# Standard LibrePortal tag replacements for common configuration values
|
|
||||||
# Now uses universal tag manager instead of sed operations
|
|
||||||
tagsProcessorStandardReplacements()
|
|
||||||
{
|
|
||||||
local full_file_path="$1"
|
|
||||||
local domain_full="$2"
|
|
||||||
local host_setup="$3"
|
|
||||||
local domain_prefix="$4"
|
|
||||||
local public_ip_v4="$5"
|
|
||||||
local CFG_NETWORK_SUBNET="$6"
|
|
||||||
local CFG_TIMEZONE="$7"
|
|
||||||
local CFG_NETWORK_NAME="$8"
|
|
||||||
local CFG_NETWORK_MTU="$9"
|
|
||||||
local default_middleware="${10}"
|
|
||||||
|
|
||||||
echo "Applying standard LibrePortal tag replacements using universal tag manager"
|
|
||||||
|
|
||||||
# Use universal tag manager for all replacements - only update tags that exist
|
|
||||||
tagsManagerUpdateUniversalTag "$full_file_path" "DOMAINSUBNAME_TAG" "$host_setup"
|
|
||||||
tagsManagerUpdateUniversalTag "$full_file_path" "TIMEZONE_TAG" "$CFG_TIMEZONE"
|
|
||||||
tagsManagerUpdateUniversalTag "$full_file_path" "DOCKER_NETWORK_TAG" "$CFG_NETWORK_NAME"
|
|
||||||
# Host live-app-data root, passed into the WebUI container (only the
|
|
||||||
# libreportal compose carries this tag; "only update tags that exist").
|
|
||||||
tagsManagerUpdateUniversalTag "$full_file_path" "CONTAINERS_DIR_TAG" "${containers_dir%/}"
|
|
||||||
# Host system-tree configs root — absolute bind-mount source for the WebUI's
|
|
||||||
# configs/webui/* (the containers root is separate from the system tree now).
|
|
||||||
tagsManagerUpdateUniversalTag "$full_file_path" "CONFIGS_DIR_TAG" "${configs_dir%/}"
|
|
||||||
|
|
||||||
isSuccessful "Standard LibrePortal tag replacements applied using universal tag manager"
|
|
||||||
}
|
|
||||||
@ -14,6 +14,8 @@ cli_scripts=(
|
|||||||
"cli/commands/backup/cli_backup_header.sh"
|
"cli/commands/backup/cli_backup_header.sh"
|
||||||
"cli/commands/config/cli_config_commands.sh"
|
"cli/commands/config/cli_config_commands.sh"
|
||||||
"cli/commands/config/cli_config_header.sh"
|
"cli/commands/config/cli_config_header.sh"
|
||||||
|
"cli/commands/debug/cli_debug_commands.sh"
|
||||||
|
"cli/commands/debug/cli_debug_header.sh"
|
||||||
"cli/commands/dockertype/cli_dockertype_commands.sh"
|
"cli/commands/dockertype/cli_dockertype_commands.sh"
|
||||||
"cli/commands/dockertype/cli_dockertype_header.sh"
|
"cli/commands/dockertype/cli_dockertype_header.sh"
|
||||||
"cli/commands/firewall/cli_firewall_commands.sh"
|
"cli/commands/firewall/cli_firewall_commands.sh"
|
||||||
|
|||||||
@ -47,7 +47,6 @@ config_scripts=(
|
|||||||
"config/tags/processors/tags_processor_random_user.sh"
|
"config/tags/processors/tags_processor_random_user.sh"
|
||||||
"config/tags/processors/tags_processor_socket_configuration.sh"
|
"config/tags/processors/tags_processor_socket_configuration.sh"
|
||||||
"config/tags/processors/tags_processor_speedtest_pass.sh"
|
"config/tags/processors/tags_processor_speedtest_pass.sh"
|
||||||
"config/tags/processors/tags_processor_standard_replacements.sh"
|
|
||||||
"config/tags/processors/tags_processor_traefik_control.sh"
|
"config/tags/processors/tags_processor_traefik_control.sh"
|
||||||
"config/tags/processors/tags_processor_trusted_domains.sh"
|
"config/tags/processors/tags_processor_trusted_domains.sh"
|
||||||
"config/utils/update_whitelist.sh"
|
"config/utils/update_whitelist.sh"
|
||||||
|
|||||||
@ -28,5 +28,7 @@ source_scripts=(
|
|||||||
"source/files/arrays/files_start.sh"
|
"source/files/arrays/files_start.sh"
|
||||||
"source/files/arrays/files_update.sh"
|
"source/files/arrays/files_update.sh"
|
||||||
"source/files/arrays/files_webui.sh"
|
"source/files/arrays/files_webui.sh"
|
||||||
|
"source/files/arrays/function_manifest.sh"
|
||||||
|
"source/files/generate_function_manifest.sh"
|
||||||
|
|
||||||
)
|
)
|
||||||
|
|||||||
@ -781,7 +781,6 @@ declare -gA LP_FN_MAP=(
|
|||||||
[tagsProcessorRandomUserGeneration]="config/tags/processors/tags_processor_random_user.sh"
|
[tagsProcessorRandomUserGeneration]="config/tags/processors/tags_processor_random_user.sh"
|
||||||
[tagsProcessorSocketConfiguration]="config/tags/processors/tags_processor_socket_configuration.sh"
|
[tagsProcessorSocketConfiguration]="config/tags/processors/tags_processor_socket_configuration.sh"
|
||||||
[tagsProcessorSpeedtestPass]="config/tags/processors/tags_processor_speedtest_pass.sh"
|
[tagsProcessorSpeedtestPass]="config/tags/processors/tags_processor_speedtest_pass.sh"
|
||||||
[tagsProcessorStandardReplacements]="config/tags/processors/tags_processor_standard_replacements.sh"
|
|
||||||
[tagsProcessorTraefikControl]="config/tags/processors/tags_processor_traefik_control.sh"
|
[tagsProcessorTraefikControl]="config/tags/processors/tags_processor_traefik_control.sh"
|
||||||
[tagsProcessorTrustedDomains]="config/tags/processors/tags_processor_trusted_domains.sh"
|
[tagsProcessorTrustedDomains]="config/tags/processors/tags_processor_trusted_domains.sh"
|
||||||
[tailscaleInstallToContainer]="headscale/scripts/tailscale_install.sh"
|
[tailscaleInstallToContainer]="headscale/scripts/tailscale_install.sh"
|
||||||
@ -1644,7 +1643,6 @@ declare -gA LP_FN_ROOT=(
|
|||||||
[tagsProcessorRandomUserGeneration]="scripts"
|
[tagsProcessorRandomUserGeneration]="scripts"
|
||||||
[tagsProcessorSocketConfiguration]="scripts"
|
[tagsProcessorSocketConfiguration]="scripts"
|
||||||
[tagsProcessorSpeedtestPass]="scripts"
|
[tagsProcessorSpeedtestPass]="scripts"
|
||||||
[tagsProcessorStandardReplacements]="scripts"
|
|
||||||
[tagsProcessorTraefikControl]="scripts"
|
[tagsProcessorTraefikControl]="scripts"
|
||||||
[tagsProcessorTrustedDomains]="scripts"
|
[tagsProcessorTrustedDomains]="scripts"
|
||||||
[tailscaleInstallToContainer]="containers"
|
[tailscaleInstallToContainer]="containers"
|
||||||
@ -2525,7 +2523,6 @@ tagsProcessorPortSubdomains() { source "${install_scripts_dir}network/traefik/tr
|
|||||||
tagsProcessorRandomUserGeneration() { source "${install_scripts_dir}config/tags/processors/tags_processor_random_user.sh"; tagsProcessorRandomUserGeneration "$@"; }
|
tagsProcessorRandomUserGeneration() { source "${install_scripts_dir}config/tags/processors/tags_processor_random_user.sh"; tagsProcessorRandomUserGeneration "$@"; }
|
||||||
tagsProcessorSocketConfiguration() { source "${install_scripts_dir}config/tags/processors/tags_processor_socket_configuration.sh"; tagsProcessorSocketConfiguration "$@"; }
|
tagsProcessorSocketConfiguration() { source "${install_scripts_dir}config/tags/processors/tags_processor_socket_configuration.sh"; tagsProcessorSocketConfiguration "$@"; }
|
||||||
tagsProcessorSpeedtestPass() { source "${install_scripts_dir}config/tags/processors/tags_processor_speedtest_pass.sh"; tagsProcessorSpeedtestPass "$@"; }
|
tagsProcessorSpeedtestPass() { source "${install_scripts_dir}config/tags/processors/tags_processor_speedtest_pass.sh"; tagsProcessorSpeedtestPass "$@"; }
|
||||||
tagsProcessorStandardReplacements() { source "${install_scripts_dir}config/tags/processors/tags_processor_standard_replacements.sh"; tagsProcessorStandardReplacements "$@"; }
|
|
||||||
tagsProcessorTraefikControl() { source "${install_scripts_dir}config/tags/processors/tags_processor_traefik_control.sh"; tagsProcessorTraefikControl "$@"; }
|
tagsProcessorTraefikControl() { source "${install_scripts_dir}config/tags/processors/tags_processor_traefik_control.sh"; tagsProcessorTraefikControl "$@"; }
|
||||||
tagsProcessorTrustedDomains() { source "${install_scripts_dir}config/tags/processors/tags_processor_trusted_domains.sh"; tagsProcessorTrustedDomains "$@"; }
|
tagsProcessorTrustedDomains() { source "${install_scripts_dir}config/tags/processors/tags_processor_trusted_domains.sh"; tagsProcessorTrustedDomains "$@"; }
|
||||||
tailscaleInstallToContainer() { source "${install_containers_dir}headscale/scripts/tailscale_install.sh"; tailscaleInstallToContainer "$@"; }
|
tailscaleInstallToContainer() { source "${install_containers_dir}headscale/scripts/tailscale_install.sh"; tailscaleInstallToContainer "$@"; }
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user