Webstar/LibrePortal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(backup/webui): show the retention "Backup style" divider only for Custom

Browse Source 
.backup-retention-preset-block carried a permanent border-bottom (+ padding),
but the Keep-* fields it separates the dropdown from are hidden for every
preset except Custom — so on Self-hosting/etc. it was an orphaned line with
empty space beneath it. Moved the divider + spacing onto an .is-custom state
that applyVisibility() toggles alongside the fields.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
librelad 2026-07-07 22:25:03 +01:00
parent 34102eb6db
commit 41786edd36
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
containers/libreportal/frontend/components/backup/configuration/js/backup-retention-presets.js
View File

@ -64,6 +64,9 @@ Object.assign(BackupPage.prototype, {
const applyVisibility = (presetKey) => { const applyVisibility = (presetKey) => {
const isCustom = presetKey === 'custom'; const isCustom = presetKey === 'custom';
// Gate the block's divider on custom too — it separates the dropdown
// from the Keep-* fields, which only show in the custom state.
block.classList.toggle('is-custom', isCustom);
wrappers.forEach(w => { if (w) w.style.display = isCustom ? '' : 'none'; }); wrappers.forEach(w => { if (w) w.style.display = isCustom ? '' : 'none'; });
}; };
applyVisibility(preset); applyVisibility(preset);

7
containers/libreportal/frontend/components/backup/core/css/backup.css
View File

@ -713,6 +713,13 @@
display: flex; display: flex;
flex-direction: column; flex-direction: column;
gap: 6px; gap: 6px;
}
/* The divider (and its spacing) belongs only to the "Custom" state: the Keep-*
fields it separates the dropdown from are hidden for every preset except
custom, so otherwise it's an orphaned line under the dropdown. The .is-custom
class is toggled by applyVisibility() in the retention enhancer. */
.backup-retention-preset-block.is-custom {
padding-bottom: 14px; padding-bottom: 14px;
margin-bottom: 6px; margin-bottom: 6px;
border-bottom: 1px solid rgba(var(--text-rgb), 0.08); border-bottom: 1px solid rgba(var(--text-rgb), 0.08);