Webstar/LibrePortal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(rootless): enumerate containers/ as its owner, not the manager

Browse Source 
Bare `find "$containers_dir"` runs as the manager, but under rootless
containers/ is dockerinstall-owned 751 (traversable, not list-readable by
the manager) -> "find: /docker/containers/: Permission denied". For the
app-log generator that was cosmetic; for dockerComposeUpAllApps /
dockerComposeDownAllApps it silently enumerates nothing so no apps come
up/down. Route these through runFileOp find (dockerinstall in rootless,
manager in rooted — correct in both). The two docker-type switcher finds
are deliberately left: mid-switch the at-rest container owner can differ
from the target-mode user runFileOp resolves to, so they need mode-aware
handling rather than a blind swap.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
This commit is contained in:
librelad 2026-05-24 21:46:17 +01:00
parent c1616bff75
commit 22364f5421
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
scripts/docker/app/compose/down_all.sh
View File

@ -3,7 +3,10 @@
dockerComposeDownAllApps() dockerComposeDownAllApps()
{ {
local type="$1" local type="$1"
local subdirectories=($(find "$containers_dir" -mindepth 1 -maxdepth 1 -type d)) # runFileOp: containers/ is owned by the container user (dockerinstall, 751)
# under rootless and isn't list-readable by the manager — enumerate as the
# owner or this silently finds nothing and no apps get brought down.
local subdirectories=($(runFileOp find "$containers_dir" -mindepth 1 -maxdepth 1 -type d))
for dir in "${subdirectories[@]}"; do for dir in "${subdirectories[@]}"; do
local app_name=$(basename "$dir") local app_name=$(basename "$dir")

5
scripts/docker/app/compose/up_all.sh
View File

@ -3,7 +3,10 @@
dockerComposeUpAllApps() dockerComposeUpAllApps()
{ {
local type="$1" local type="$1"
local subdirectories=($(find "$containers_dir" -mindepth 1 -maxdepth 1 -type d)) # runFileOp: containers/ is owned by the container user (dockerinstall, 751)
# under rootless and isn't list-readable by the manager — enumerate as the
# owner or this silently finds nothing and no apps come up.
local subdirectories=($(runFileOp find "$containers_dir" -mindepth 1 -maxdepth 1 -type d))
for dir in "${subdirectories[@]}"; do for dir in "${subdirectories[@]}"; do
local app_name=$(basename "$dir") local app_name=$(basename "$dir")

2
scripts/webui/data/logs/webui_app_logs.sh
View File

@ -14,7 +14,7 @@ webuiGenerateAppLogs()
# Fast approach: Scan containers directory directly # Fast approach: Scan containers directory directly
if [ -d "$containers_dir" ]; then if [ -d "$containers_dir" ]; then
find "$containers_dir" -maxdepth 1 -type d -not -path "$containers_dir" | while read -r dir; do runFileOp find "$containers_dir" -maxdepth 1 -type d -not -path "$containers_dir" | while read -r dir; do
local result=$(basename "$dir") local result=$(basename "$dir")
local app_name="$result" local app_name="$result"
total_apps=$((total_apps + 1)) total_apps=$((total_apps + 1))