From 10ce8a1453793462c235b090863ed54e96033f2e Mon Sep 17 00:00:00 2001 From: librelad Date: Thu, 25 Jun 2026 12:47:10 +0100 Subject: [PATCH] style(docker/rootless): trim tombstone comment in rootless user setup Describe only the current useradd behaviour; drop the narration of the old silent-failure bug (per the repo's no-tombstone-comments convention). Co-Authored-By: Claude Opus 4.8 Signed-off-by: librelad --- scripts/docker/install/rootless/rootless_user.sh | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/scripts/docker/install/rootless/rootless_user.sh b/scripts/docker/install/rootless/rootless_user.sh index 051c0ad..961605e 100755 --- a/scripts/docker/install/rootless/rootless_user.sh +++ b/scripts/docker/install/rootless/rootless_user.sh @@ -6,12 +6,10 @@ installDockerRootlessUser() if id "$CFG_DOCKER_INSTALL_USER" &>/dev/null; then isSuccessful "User $CFG_DOCKER_INSTALL_USER already exists." else - # Create the rootless docker user. The login name (last arg) was - # missing, so useradd failed silently — masked by local result; result=$(...) - # — and the user never existed, breaking the whole rootless setup. - # -m makes its home; with SUB_UID/GID configured in login.defs, - # useradd also assigns its subordinate uid/gid ranges (needed for - # rootless). Run unmasked so checkSuccess sees real failures. + # Create the rootless docker user. -m makes its home; with SUB_UID/GID + # configured in login.defs, useradd also assigns its subordinate uid/gid + # ranges (needed for rootless). Run unmasked so checkSuccess sees real + # failures. runSystem useradd -m -s /bin/bash -d "/home/$CFG_DOCKER_INSTALL_USER" "$CFG_DOCKER_INSTALL_USER" checkSuccess "Creating $CFG_DOCKER_INSTALL_USER User." fi