From 0724ed785a3ea3416467221f9498932db17a3d3f Mon Sep 17 00:00:00 2001
From: librelad <librelad@digitalangels.vip>
Date: Fri, 29 May 2026 23:52:51 +0100
Subject: [PATCH] feat(webui): load feature modules from the manifest (drop
 index.html script list)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The kernel now loads each feature's self-registering index.js from the
manifest (new 'module' field) before building routes, so index.html no
longer hardcodes a per-feature <script> list — one of the four registries
the modularization targets is now gone. Adding a page = drop a
features/<id>/ folder + a manifest entry; no index.html edit.

loadScript is idempotent and non-fatal: a module that 404s or fails to
register leaves its route on the legacy handler. Manifest-load failure
still falls back to the built-in route table.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: librelad <librelad@digitalangels.vip>
---
 .../libreportal/frontend/features/manifest.dev.json  |  8 +++++++-
 containers/libreportal/frontend/index.html           | 12 ++++--------
 containers/libreportal/frontend/js/spa.js            | 11 +++++++++++
 3 files changed, 22 insertions(+), 9 deletions(-)

diff --git a/containers/libreportal/frontend/features/manifest.dev.json b/containers/libreportal/frontend/features/manifest.dev.json
index cdd5bd5..2c6cf35 100644
--- a/containers/libreportal/frontend/features/manifest.dev.json
+++ b/containers/libreportal/frontend/features/manifest.dev.json
@@ -1,10 +1,11 @@
 {
   "version": 1,
-  "note": "Phase-0 hand-committed manifest. Mirrors spa.js setupRoutes() exactly. Will be replaced by the generated /data/webui/generated/features.json once the scan generator lands (see docs/frontend-modularization.md). 'handler' names the LibrePortalSPAClean method that still does the rendering during the strangler migration; 'navId' is the existing topbar element id for active-state highlighting.",
+  "note": "Phase-0 hand-committed manifest (to be replaced by the generated /data/webui/generated/features.json once the scan generator lands — see docs/frontend-modularization.md). 'module' is the feature's self-registering index.js; the kernel loads these from here so they no longer need <script> tags in index.html. 'handler' names the LibrePortalSPAClean method kept as the fallback during the strangler migration; 'navId' is the topbar element id for active-state highlighting.",
   "features": [
     {
       "id": "dashboard",
       "routes": ["/", "/dashboard"],
+      "module": "/features/dashboard/index.js",
       "handler": "handleDashboard",
       "navId": "nav-dashboard",
       "nav": { "label": "Dashboard", "order": 10 }
@@ -12,6 +13,7 @@
     {
       "id": "apps",
       "routes": ["/apps", "/apps*"],
+      "module": "/features/apps/index.js",
       "handler": "handleApps",
       "navId": "nav-app-center",
       "nav": { "label": "App Center", "order": 20 }
@@ -19,12 +21,14 @@
     {
       "id": "app-detail",
       "routes": ["/app", "/app*"],
+      "module": "/features/app-detail/index.js",
       "handler": "handleAppDetail",
       "navId": "nav-app-center"
     },
     {
       "id": "admin",
       "routes": ["/admin", "/admin*"],
+      "module": "/features/admin/index.js",
       "handler": "handleAdmin",
       "navId": "nav-config",
       "nav": { "label": "Admin", "order": 40 }
@@ -38,6 +42,7 @@
     {
       "id": "tasks",
       "routes": ["/tasks", "/tasks*"],
+      "module": "/features/tasks/index.js",
       "handler": "handleTasks",
       "navId": "nav-tasks",
       "nav": { "label": "Tasks", "order": 60 }
@@ -45,6 +50,7 @@
     {
       "id": "backup",
       "routes": ["/backup", "/backup*"],
+      "module": "/features/backup/index.js",
       "handler": "handleBackup",
       "navId": "nav-backup",
       "nav": { "label": "Backups", "order": 50 }
diff --git a/containers/libreportal/frontend/index.html b/containers/libreportal/frontend/index.html
index 69eaf03..cc306be 100755
--- a/containers/libreportal/frontend/index.html
+++ b/containers/libreportal/frontend/index.html
@@ -109,14 +109,10 @@
        docs/frontend-modularization.md. -->
   <script src="/kernel/feature-registry.js"></script>
   <script src="/kernel/lifecycle.js"></script>
-  <!-- Feature modules self-register here (eager, tiny). Their heavy controllers
-       are still lazy-loaded by the module's mount(). -->
-  <script src="/features/dashboard/index.js"></script>
-  <script src="/features/apps/index.js"></script>
-  <script src="/features/app-detail/index.js"></script>
-  <script src="/features/admin/index.js"></script>
-  <script src="/features/backup/index.js"></script>
-  <script src="/features/tasks/index.js"></script>
+  <!-- Feature modules are NOT listed here: the kernel loads each feature's
+       self-registering index.js from the manifest (features/manifest.dev.json)
+       before routing. Adding a page = drop a features/<id>/ folder + a manifest
+       entry, no index.html edit. Heavy controllers stay lazy (loaded by mount). -->
   <!--
     Page-specific controllers are loaded on demand by spa.js / config-manager.js
     when the user navigates to the relevant route. Keeping them out of the
diff --git a/containers/libreportal/frontend/js/spa.js b/containers/libreportal/frontend/js/spa.js
index f194024..7c3f2a0 100755
--- a/containers/libreportal/frontend/js/spa.js
+++ b/containers/libreportal/frontend/js/spa.js
@@ -102,6 +102,17 @@ class LibrePortalSPAClean {
         this.setupRoutes();
         return;
       }
+
+      // Load each feature's self-registering module (if declared) BEFORE building
+      // routes, so LP.features.get(id) sees the registered mount(). This is what
+      // lets index.html drop its per-feature <script> list — the manifest is the
+      // one place a feature is declared. loadScript is idempotent + non-fatal: a
+      // module that 404s or fails to register simply leaves that route on its
+      // legacy handler.
+      const modules = [...new Set(entries.map(f => f.module).filter(Boolean))];
+      await Promise.all(modules.map(src =>
+        this.loadScript(src).catch(err => console.warn(`[spa] feature module "${src}" failed to load:`, err))
+      ));
       // All-or-nothing: a single missing handler means we don't trust the
       // manifest enough to route from it — use the known-good built-in table.
       for (const f of entries) {